Skip to content

test: ws build tx without sign and lock#1024

Merged
raul-oliveira merged 1 commit intofeat/build-tx-without-sign-and-lockfrom
test/ws-build-tx-without-sign-and-lock
Mar 3, 2026
Merged

test: ws build tx without sign and lock#1024
raul-oliveira merged 1 commit intofeat/build-tx-without-sign-and-lockfrom
test/ws-build-tx-without-sign-and-lock

Conversation

@raul-oliveira
Copy link
Copy Markdown
Contributor

Acceptance Criteria

  • wallet service test suite for build and sign nano tx

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 3, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch test/ws-build-tx-without-sign-and-lock

Comment @coderabbitai help to get the list of available commands and usage tips.

@raul-oliveira raul-oliveira requested a review from tuliomir March 3, 2026 16:17
@raul-oliveira raul-oliveira self-assigned this Mar 3, 2026
@raul-oliveira raul-oliveira moved this from Todo to In Progress (Done) in Hathor Network Mar 3, 2026
@raul-oliveira raul-oliveira merged commit d1513a7 into feat/build-tx-without-sign-and-lock Mar 3, 2026
1 check passed
@github-project-automation github-project-automation bot moved this from In Progress (Done) to Waiting to be deployed in Hathor Network Mar 3, 2026
raul-oliveira added a commit that referenced this pull request Mar 5, 2026
* feat: create nano contract tx without signing

* review changes: remove prepareToSend

* review changes: removed pin when not signing and simplified address

* review changes: separate tests

* feat: create nano contract create token tx

* test: ws build tx without sign and lock (#1024)

* tests: wallet-service createNanoContractCreateTokenTransaction

* fix: missing types

* fix: linter errors

* review changes: change caller and signtx methods for nano

* revie changes: add unit test and move helpers

* review changes: docstrings fixes, and refactors
@raul-oliveira raul-oliveira moved this from Waiting to be deployed to Done in Hathor Network Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant