Merged
Conversation
pedroferreira1
requested changes
Jun 3, 2019
Member
pedroferreira1
left a comment
pedroferreira1
left a comment
There was a problem hiding this comment.
I think we should have a place in the README explaining how to set a storage and what we expect (a getItem, a setItem, ...)
pedroferreira1
approved these changes
Jun 5, 2019
msbrogli
requested changes
Jun 5, 2019
Member
I agree with it. |
msbrogli
approved these changes
Jun 5, 2019
| const storageFactory = { | ||
| class MemoryOnlyStore { | ||
| constructor() { | ||
| this.hathorMemoryStorage = {}; |
Member
There was a problem hiding this comment.
I this you just kept the variable name, but I think data or store would be a better name.
Member
Author
There was a problem hiding this comment.
This is just internal, not used outside the class.
tuliomir
added a commit
that referenced
this pull request
Mar 23, 2026
Enables readonly wallet testing for the wallet-service facade and reorganizes readonly tests into shared vs. facade-specific: - Service adapter: adds xpub support in buildWalletInstance/startWallet, routing to startReadOnly() for xpub wallets. Pre-registers the wallet on the backend (via seed start+stop) before attaching as readonly. - Shared tests: isReadonly verification, zero balance, fund injection — run against both facades via describe.each. - Fullnode-specific: address generation (local derivation) and 15 WalletFromXPubGuard assertions. - Service-specific: 5 WalletFromXPubGuard assertions for guarded methods. - Helper: buildWalletInstance() now accepts optional xpub parameter. Addresses PR review comment #1 about wallet-service readonly support. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lib now doesn't require localStorage and clients should pass a storage to the lib using
setStorage().