Conversation
tuliomir
requested changes
Jan 5, 2024
| "format": "npm run eslint:fix && npm run code:format", | ||
| "eslint": "eslint src/**/*.{ts,css,js,html} test/**/*.ts", | ||
| "eslint:fix": "eslint --fix src/**/*.ts test/**/*.ts", | ||
| "code:format": "prettier --write src/**/*.ts test/**/*.ts", |
tuliomir
reviewed
Jan 8, 2024
tuliomir
approved these changes
Jan 8, 2024
pedroferreira1
approved these changes
Jan 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
This is a healthcheck lib very similar to the one we built for Python (https://github.com/HathorNetwork/python-healthcheck-lib)
Its main goal is to make sure we will use the same response format for healthchecks across all our Javascript projects.
The healthcheck logic itself will be provided by the projects that use the lib, through callbacks.
More info in the README.md file included.