Skip to content

chore: update dependencies#998

Merged
glevco merged 1 commit intomasterfrom
chore/update-deps
Aug 20, 2024
Merged

chore: update dependencies#998
glevco merged 1 commit intomasterfrom
chore/update-deps

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Apr 8, 2024

Motivation

This PR updates some of our most important dependencies, fixing bugs, improving security, and possibly increasing performance. It resolves https://github.com/HathorNetwork/sec-hathor-core/issues/137.

Breaking changes

I read the changelog of the most important dependencies to check if there was anything relevant. Here's the list:

Cryptography (Changelog)

  • BACKWARDS INCOMPATIBLE: Support for OpenSSL less than 1.1.1d has been removed. Users on older version of OpenSSL will need to upgrade.
  • BACKWARDS INCOMPATIBLE: Dropped support for LibreSSL < 3.7.
  • BACKWARDS INCOMPATIBLE: Dropped support for macOS 10.10 and 10.11, macOS users must upgrade to 10.12 or newer.

pyOpenSSL (Changelog)

  • No relevant changes.

Twisted (Changelog)

  • Twisted now officially supports Python 3.11.

Acceptance Criteria

  • Update the following dev-dependencies to their respective latest version:
    • flake8
    • isort
    • mypy
    • mypy-zope
    • pytest
    • pytest-cov
    • flaky
    • pytest-xdist
    • yamllint
  • Update the following dependencies to their respective latest version (ATTENTION: this includes updates to important dependencies like twisted and cryptography):
    • twisted
    • autobahn
    • cryptography
    • pyopenssl
    • requests
    • aiohttp
    • setproctitle
    • hathorlib
    • pydantic
    • typing-extensions

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco added the dependencies Pull requests that update a dependency file label Apr 8, 2024
@glevco glevco self-assigned this Apr 8, 2024
@glevco glevco force-pushed the chore/update-deps branch from b94f39f to 651f1f5 Compare April 8, 2024 23:44
@glevco glevco marked this pull request as ready for review April 9, 2024 00:14
@glevco glevco requested review from jansegre and msbrogli as code owners April 9, 2024 00:14
msbrogli
msbrogli previously approved these changes Apr 24, 2024
@glevco glevco force-pushed the chore/update-deps branch from 651f1f5 to ba73428 Compare August 13, 2024 21:14
@github-actions
Copy link

github-actions bot commented Aug 13, 2024

🐰Bencher

ReportTue, August 20, 2024 at 18:16:09 UTC
Projecthathor-core
Branchchore/update-deps
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Lower Boundary
nanoseconds (ns) | (%)
Latency Upper Boundary
nanoseconds (ns) | (%)
sync-v2 (up to 20000 blocks)✅ (view plot)101,430,955,862.74 (-1.95%)82,758,791,930.82 (81.59%)124,138,187,896.23 (81.71%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@glevco glevco force-pushed the chore/update-deps branch 2 times, most recently from 68dd68d to 27c1a6d Compare August 13, 2024 23:00
@codecov
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.85%. Comparing base (78dcca1) to head (de68203).
Report is 1 commits behind head on master.

Files Patch % Lines
hathor/wallet/resources/thin_wallet/send_tokens.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #998      +/-   ##
==========================================
- Coverage   84.88%   84.85%   -0.03%     
==========================================
  Files         315      315              
  Lines       24070    24071       +1     
  Branches     3647     3647              
==========================================
- Hits        20431    20425       -6     
- Misses       2926     2929       +3     
- Partials      713      717       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the chore/update-deps branch from 27c1a6d to af62a20 Compare August 15, 2024 02:54
jansegre
jansegre previously approved these changes Aug 15, 2024
@glevco glevco force-pushed the chore/update-deps branch from 6fa4ce9 to de68203 Compare August 20, 2024 18:13
@glevco glevco merged commit 7f03142 into master Aug 20, 2024
@glevco glevco deleted the chore/update-deps branch August 20, 2024 18:56
@jansegre jansegre mentioned this pull request Oct 4, 2024
2 tasks
@jansegre jansegre mentioned this pull request Dec 11, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants