Conversation
b94f39f to
651f1f5
Compare
glevco
commented
Apr 8, 2024
msbrogli
previously approved these changes
Apr 24, 2024
651f1f5 to
ba73428
Compare
|
| Report | Tue, August 20, 2024 at 18:16:09 UTC |
| Project | hathor-core |
| Branch | chore/update-deps |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Lower Boundary nanoseconds (ns) | (%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | ✅ (view plot) | 101,430,955,862.74 (-1.95%) | 82,758,791,930.82 (81.59%) | 124,138,187,896.23 (81.71%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
68dd68d to
27c1a6d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #998 +/- ##
==========================================
- Coverage 84.88% 84.85% -0.03%
==========================================
Files 315 315
Lines 24070 24071 +1
Branches 3647 3647
==========================================
- Hits 20431 20425 -6
- Misses 2926 2929 +3
- Partials 713 717 +4 ☔ View full report in Codecov by Sentry. |
27c1a6d to
af62a20
Compare
jansegre
previously approved these changes
Aug 15, 2024
af62a20 to
fb2da1b
Compare
fb2da1b to
6fa4ce9
Compare
jansegre
approved these changes
Aug 20, 2024
msbrogli
approved these changes
Aug 20, 2024
6fa4ce9 to
de68203
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR updates some of our most important dependencies, fixing bugs, improving security, and possibly increasing performance. It resolves https://github.com/HathorNetwork/sec-hathor-core/issues/137.
Breaking changes
I read the changelog of the most important dependencies to check if there was anything relevant. Here's the list:
Cryptography (Changelog)
pyOpenSSL (Changelog)
Twisted (Changelog)
Acceptance Criteria
twistedandcryptography):Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged