refactor: remove deprecated resource method from address history API#994
Merged
pedroferreira1 merged 1 commit intomasterfrom Apr 4, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #994 +/- ##
==========================================
- Coverage 85.08% 85.06% -0.02%
==========================================
Files 296 296
Lines 22925 22901 -24
Branches 3452 3447 -5
==========================================
- Hits 19505 19480 -25
Misses 2734 2734
- Partials 686 687 +1 ☔ View full report in Codecov by Sentry. |
glevco
approved these changes
Apr 4, 2024
jansegre
approved these changes
Apr 4, 2024
pedroferreira1
deleted the
refactor/remove-deprecated-resource-address-history
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We deprecated the
address_historyAPI withoutpaginate=trueparameter on March 2020 (a8ae6d8). This API has low performance for addresses with many transactions and that's why it was deprecated.After many years, we are removing it to prevent someone from using it by mistake and consuming the full node's CPU.
Acceptance Criteria
address_historyAPI.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged