fix(util): division by zero when logging progress in some cases#980
Merged
fix(util): division by zero when logging progress in some cases#980
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #980 +/- ##
==========================================
- Coverage 85.09% 85.03% -0.06%
==========================================
Files 294 294
Lines 22798 22800 +2
Branches 3434 3435 +1
==========================================
- Hits 19400 19389 -11
- Misses 2712 2725 +13
Partials 686 686 ☔ View full report in Codecov by Sentry. |
msbrogli
approved these changes
Mar 21, 2024
glevco
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When testing #938 I got a division by zero error. I haven't debugged if the situation is realistic, but either way it seems to be better to handle the case where the denominator is 0.
Acceptance Criteria
progress_ == 0by simply doingremaining_time = '?'Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged