Conversation
msbrogli
requested changes
Mar 21, 2024
glevco
force-pushed
the
fix/improve-alerts
branch
from
9f143e3 to
f70cdaa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #965 +/- ##
==========================================
+ Coverage 85.09% 85.12% +0.03%
==========================================
Files 295 295
Lines 22864 22866 +2
Branches 3443 3443
==========================================
+ Hits 19456 19465 +9
+ Misses 2721 2717 -4
+ Partials 687 684 -3 ☔ View full report in Codecov by Sentry. |
glevco
force-pushed
the
fix/improve-alerts
branch
from
f70cdaa to
fdf1307
Compare
msbrogli
approved these changes
Mar 22, 2024
jansegre
approved these changes
Mar 22, 2024
glevco
force-pushed
the
fix/improve-alerts
branch
from
fdf1307 to
ee13923
Compare
glevco
force-pushed
the
fix/improve-alerts
branch
from
ee13923 to
e0bd903
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
failed to download txalerts currently spams our on-call engineer unnecessarily. There are two places where this can happen, and both generate alerts for different reasons (1a, 1b, 1c and 2a, 2b).This PR prevents alerts caused by Twisted's
CancelledErrorin case 1, which are not necessary. For case 2, we simply improve the logs to understand its root cause in a future release.Acceptance Criteria
CancelledErrorand add traceback to logs.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged