feat(feature-activation): implement bit signaling sysctl#962
Merged
Conversation
bdf3a43 to
139577d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #962 +/- ##
===========================================
+ Coverage 0 85.04% +85.04%
===========================================
Files 0 296 +296
Lines 0 22918 +22918
Branches 0 3451 +3451
===========================================
+ Hits 0 19490 +19490
- Misses 0 2741 +2741
- Partials 0 687 +687 ☔ View full report in Codecov by Sentry. |
This was referenced Feb 29, 2024
msbrogli
requested changes
Mar 1, 2024
3ef4d62 to
be9a2de
Compare
jansegre
approved these changes
Mar 22, 2024
jansegre
approved these changes
Mar 22, 2024
msbrogli
approved these changes
Apr 2, 2024
be9a2de to
8a864eb
Compare
8a864eb to
4b44a2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add sysctl commands to control Feature Activation bit signaling without having to restart the full node (previously, this was only available through CLI options). The commands are the following:
core.features.supported_featuresReturn features that are explicitly enabled. Read-only.
core.features.not_supported_featuresReturn features that are explicitly disabled. Read-only.
core.features.signaling_featuresReturn which feature are currently in a signaling phase. Read-only.
core.features.add_supportAdd support for a feature. Write-only.
core.features.remove_supportRemove support for a feature. Write-only.
Example
Then, the bits in the block template will be changed accordingly.
Acceptance Criteria
core.featuressysctl command group with the following subcommands:supported_features,not_supported_features,signaling_features,add_support, andremove_support.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged