fix: Fix slow tx processing on some edge cases

[msbrogli]

Motivation

We got this issue during the QA of hathor-core v0.59.0-rc1. This is triggered when a node does a sync from scratch using sync-v2 and, later on, switches to sync-v1. The sync-v1 works properly but the processing of some transactions get considerably slower.

Fixes https://github.com/HathorNetwork/internal-issues/issues/246.

Acceptance Criteria

1. Stop marking transactions confirmed by the best blockchain as voided during conflict resolution. Notice that this edge case only occurs when the conflicting transaction is soft voided and is confirmed by the best blockchain.

Checklist

• If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.12%. Comparing base (7876fa5) to head (318711e).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #957      +/-   ##
==========================================
- Coverage   85.21%   85.12%   -0.10%     
==========================================
  Files         292      292              
  Lines       22661    22664       +3     
  Branches     3413     3414       +1     
==========================================
- Hits        19310    19292      -18     
- Misses       2683     2694      +11     
- Partials      668      678      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.