fix(cli): Fix issue when running sysctl through USR2 in macOS#956
Merged
fix(cli): Fix issue when running sysctl through USR2 in macOS#956
Conversation
7bc93d1 to
06980f3
Compare
jansegre
previously approved these changes
Feb 16, 2024
pedroferreira1
previously approved these changes
Feb 16, 2024
5d059ca
06980f3 to
5d059ca
Compare
jansegre
approved these changes
Feb 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #956 +/- ##
==========================================
- Coverage 85.42% 85.31% -0.12%
==========================================
Files 292 292
Lines 22568 22581 +13
Branches 3395 3401 +6
==========================================
- Hits 19278 19264 -14
- Misses 2621 2641 +20
- Partials 669 676 +7 ☔ View full report in Codecov by Sentry. |
pedroferreira1
approved these changes
Feb 16, 2024
5d059ca to
00967a7
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
macOS has a different behavior when handling named pipes created by
mkfifo.In macOS, if a fifo is opened for reading, the
open()call will block if there are no writers—that is, if somebody else does not have the fifo open for writing.In Linux, the
open()call is not blocking so the previous code worked fine and logged the fifo path as expected.Acceptance Criteria
open()call fromtemp_fifo().open()after logging the fifo path.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged