Skip to content

fix: test broke after #951#953

Merged
jansegre merged 1 commit intomasterfrom
fix/sysctl-profiler-test
Feb 15, 2024
Merged

fix: test broke after #951#953
jansegre merged 1 commit intomasterfrom
fix/sysctl-profiler-test

Conversation

@jansegre
Copy link
Member

Motivation

CI broke after #951 but the fix is trivial.

Acceptance Criteria

  • Use unsafe_set (renamed method) instead of set (old method)
  • All tests should pass

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre self-assigned this Feb 15, 2024
@jansegre jansegre requested a review from msbrogli as a code owner February 15, 2024 16:11
@codecov
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1f68ec7) 85.42% compared to head (d885d7f) 85.28%.
Report is 1 commits behind head on master.

Files Patch % Lines
hathor/sysctl/runner.py 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #953      +/-   ##
==========================================
- Coverage   85.42%   85.28%   -0.14%     
==========================================
  Files         292      292              
  Lines       22568    22581      +13     
  Branches     3395     3401       +6     
==========================================
- Hits        19278    19258      -20     
- Misses       2621     2645      +24     
- Partials      669      678       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansegre jansegre merged commit 2d51d03 into master Feb 15, 2024
@jansegre jansegre deleted the fix/sysctl-profiler-test branch February 15, 2024 16:33
@jansegre jansegre mentioned this pull request Feb 15, 2024
2 tasks
@jansegre jansegre mentioned this pull request Feb 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants