Skip to content

feat(sysctl): Add p2p.kill_connection to sysctl#950

Merged
msbrogli merged 1 commit intomasterfrom
feat/sysctl-p2p-kill-connection
Feb 9, 2024
Merged

feat(sysctl): Add p2p.kill_connection to sysctl#950
msbrogli merged 1 commit intomasterfrom
feat/sysctl-p2p-kill-connection

Conversation

@msbrogli
Copy link
Member

@msbrogli msbrogli commented Feb 9, 2024

Motivation

We currently do not have the capacity to kill connections from sysctl. The only alternative is to kill all connections using SIGUSR1.

Acceptance Criteria

  1. Add p2p.kill_connection to sysctl. The expected behavior is to kill a connection with a given peer-id or to kill all connections if the provided peer-id is "*".

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@msbrogli msbrogli requested a review from jansegre as a code owner February 9, 2024 18:41
@msbrogli msbrogli force-pushed the feat/sysctl-p2p-kill-connection branch 2 times, most recently from 2213304 to a1b160a Compare February 9, 2024 18:56
@codecov
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a7cf1ba) 85.37% compared to head (a1b160a) 85.43%.

❗ Current head a1b160a differs from pull request most recent head f4d6a28. Consider uploading reports for the commit f4d6a28 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #950      +/-   ##
==========================================
+ Coverage   85.37%   85.43%   +0.05%     
==========================================
  Files         291      290       -1     
  Lines       22526    22525       -1     
  Branches     3391     3390       -1     
==========================================
+ Hits        19232    19244      +12     
+ Misses       2624     2612      -12     
+ Partials      670      669       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msbrogli msbrogli self-assigned this Feb 9, 2024
@msbrogli msbrogli force-pushed the feat/sysctl-p2p-kill-connection branch from a1b160a to f4d6a28 Compare February 9, 2024 22:43
@msbrogli msbrogli merged commit f4d6a28 into master Feb 9, 2024
@msbrogli msbrogli deleted the feat/sysctl-p2p-kill-connection branch February 9, 2024 22:43
@jansegre jansegre mentioned this pull request Feb 15, 2024
2 tasks
@jansegre jansegre mentioned this pull request Feb 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants