feat(sysctl): Add p2p.kill_connection to sysctl#950
Merged
Conversation
2213304 to
a1b160a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #950 +/- ##
==========================================
+ Coverage 85.37% 85.43% +0.05%
==========================================
Files 291 290 -1
Lines 22526 22525 -1
Branches 3391 3390 -1
==========================================
+ Hits 19232 19244 +12
+ Misses 2624 2612 -12
+ Partials 670 669 -1 ☔ View full report in Codecov by Sentry. |
pedroferreira1
approved these changes
Feb 9, 2024
jansegre
approved these changes
Feb 9, 2024
a1b160a to
f4d6a28
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We currently do not have the capacity to kill connections from sysctl. The only alternative is to kill all connections using SIGUSR1.
Acceptance Criteria
p2p.kill_connectionto sysctl. The expected behavior is to kill a connection with a given peer-id or to kill all connections if the provided peer-id is "*".Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged