Skip to content

feat(sync-v2): Improve logging when unexpected TRANSACTIONS-END or BLOCKS-END are received #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msbrogli merged 1 commit into from
Feb 8, 2024
Merged

feat(sync-v2): Improve logging when unexpected TRANSACTIONS-END or BLOCKS-END are received #945

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hathor/p2p/sync_v2/agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,7 +721,7 @@ def handle_blocks_end(self, payload: str) -> None:
assert self.protocol.connections is not None

if self.state is not PeerState.SYNCING_BLOCKS:
self.log.error('unexpected BLOCKS-END', state=self.state)
self.log.error('unexpected BLOCKS-END', state=self.state, response_code=response_code.name)
self.protocol.send_error_and_close_connection('Not expecting to receive BLOCKS-END message')
return

Expand Down Expand Up @@ -978,7 +978,7 @@ def handle_transactions_end(self, payload: str) -> None:
assert self.protocol.connections is not None

if self.state is not PeerState.SYNCING_TRANSACTIONS:
self.log.error('unexpected TRANSACTIONS-END', state=self.state)
self.log.error('unexpected TRANSACTIONS-END', state=self.state, response_code=response_code.name)
self.protocol.send_error_and_close_connection('Not expecting to receive TRANSACTIONS-END message')
return

Expand Down