Skip to content

refactor(cli): improve handling of sync version from arguments#943

Merged
jansegre merged 1 commit intomasterfrom
chore/make-sync-v2-default
Feb 8, 2024
Merged

refactor(cli): improve handling of sync version from arguments#943
jansegre merged 1 commit intomasterfrom
chore/make-sync-v2-default

Conversation

@jansegre
Copy link
Member

@jansegre jansegre commented Feb 8, 2024

Motivation

It's getting harder to use sync-v1 in practice, might be time to switch the default to sync-v2.

Acceptance Criteria

  • Remove --sync-v2-only since it hasn't been released yet
  • Add --x-sync-v1-only
  • Hide --x-sync-2-only (default) and --x-sync-bridge (already replaced by --sync-bridge)
  • Refactor sync-choice logic to make it easier to understand
  • Add more tests to cover all sync version parameters

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre self-assigned this Feb 8, 2024
@jansegre jansegre force-pushed the chore/make-sync-v2-default branch 2 times, most recently from af40308 to 8226fc2 Compare February 8, 2024 18:03
@codecov
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8b13de7) 85.32% compared to head (d4699f9) 85.33%.
Report is 1 commits behind head on master.

❗ Current head d4699f9 differs from pull request most recent head 08f1bd4. Consider uploading reports for the commit 08f1bd4 to get more accurate results

Files Patch % Lines
hathor/builder/cli_builder.py 96.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #943   +/-   ##
=======================================
  Coverage   85.32%   85.33%           
=======================================
  Files         290      290           
  Lines       22477    22495   +18     
  Branches     3380     3385    +5     
=======================================
+ Hits        19179    19196   +17     
  Misses       2626     2626           
- Partials      672      673    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansegre jansegre force-pushed the chore/make-sync-v2-default branch from 8226fc2 to d4699f9 Compare February 8, 2024 21:17
@jansegre jansegre changed the title chore(cli): make sync-v2 default and add cli arg to use sync-v1 refactor(cli): improve handling of sync version from arguments Feb 8, 2024
@jansegre jansegre force-pushed the chore/make-sync-v2-default branch from d4699f9 to 08f1bd4 Compare February 8, 2024 21:50
@jansegre jansegre merged commit d267f62 into master Feb 8, 2024
@jansegre jansegre deleted the chore/make-sync-v2-default branch February 8, 2024 21:51
@jansegre jansegre mentioned this pull request Feb 15, 2024
2 tasks
@jansegre jansegre mentioned this pull request Feb 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants