refactor(cli): improve handling of sync version from arguments#943
Merged
refactor(cli): improve handling of sync version from arguments#943
Conversation
af40308 to
8226fc2
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #943 +/- ##
=======================================
Coverage 85.32% 85.33%
=======================================
Files 290 290
Lines 22477 22495 +18
Branches 3380 3385 +5
=======================================
+ Hits 19179 19196 +17
Misses 2626 2626
- Partials 672 673 +1 ☔ View full report in Codecov by Sentry. |
8226fc2 to
d4699f9
Compare
msbrogli
approved these changes
Feb 8, 2024
d4699f9 to
08f1bd4
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It's getting harder to use sync-v1 in practice, might be time to switch the default to sync-v2.
Acceptance Criteria
Remove--sync-v2-onlysince it hasn't been released yetAdd--x-sync-v1-only--x-sync-2-only(default) and--x-sync-bridge(already replaced by--sync-bridge)Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged