refactor(settings): rename get_settings to get_global_settings#919
Merged
refactor(settings): rename get_settings to get_global_settings#919
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #919 +/- ##
==========================================
+ Coverage 85.23% 85.29% +0.06%
==========================================
Files 285 285
Lines 22370 22370
Branches 3371 3371
==========================================
+ Hits 19066 19080 +14
+ Misses 2633 2618 -15
- Partials 671 672 +1 ☔ View full report in Codecov by Sentry. |
msbrogli
approved these changes
Jan 12, 2024
jansegre
approved these changes
Jan 12, 2024
glevco
force-pushed
the
refactor/rename-get-settings
branch
from
28d38c0 to
b4fd2a2
Compare
glevco
force-pushed
the
refactor/rename-get-settings
branch
from
b4fd2a2 to
273d228
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Rename the
get_settings()function toget_global_settings()as requested in this comment: #768 (comment)Acceptance Criteria
get_settings()function toget_global_settings().Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged