Skip to content

refactor(verification): modularize verify_scripts [part 6/7]#916

Open
glevco wants to merge 6 commits intofeat/sighash/subsetsfrom
refactor/verification/scripts
Open

refactor(verification): modularize verify_scripts [part 6/7]#916
glevco wants to merge 6 commits intofeat/sighash/subsetsfrom
refactor/verification/scripts

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jan 8, 2024

Depends on #915

Motivation

This PR is a refactor that removes all code related to script verification from the verify_inputs() method and moves it to a specific verify_scripts() method. This is simply a reorganization, as now we have multiple checks that depend on the final ScriptContext of all tx inputs, so the single method was becoming too complex.

Acceptance Criteria

  • Remove TransactionVerifier.verify_script() and implement verify_scripts().
  • No behavior should be changed.

@glevco glevco self-assigned this Jan 8, 2024
@glevco glevco added the refactor label Jan 8, 2024
@glevco glevco marked this pull request as ready for review January 8, 2024 02:10
@codecov
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (645d9b8) 85.44% compared to head (fc82c06) 85.43%.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           feat/sighash/subsets     #916      +/-   ##
========================================================
- Coverage                 85.44%   85.43%   -0.02%     
========================================================
  Files                       289      289              
  Lines                     22636    22637       +1     
  Branches                   3417     3421       +4     
========================================================
- Hits                      19341    19339       -2     
- Misses                     2618     2621       +3     
  Partials                    677      677              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the feat/sighash/subsets branch from bc45412 to 267c89a Compare January 8, 2024 20:11
@glevco glevco force-pushed the refactor/verification/scripts branch from 0b319db to 278f3e7 Compare January 8, 2024 20:11
@glevco glevco force-pushed the feat/sighash/subsets branch from 267c89a to 645d9b8 Compare January 19, 2024 22:28
@glevco glevco force-pushed the refactor/verification/scripts branch from 278f3e7 to fc82c06 Compare January 19, 2024 22:32
@glevco glevco force-pushed the feat/sighash/subsets branch from 645d9b8 to fe3fb85 Compare December 9, 2024 23:19
@glevco glevco force-pushed the refactor/verification/scripts branch from fc82c06 to ae27bbb Compare December 9, 2024 23:21
@glevco glevco force-pushed the feat/sighash/subsets branch from fe3fb85 to 17df617 Compare February 26, 2025 16:19
@glevco glevco moved this from In Review (WIP) to Todo in Hathor Network Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants