Skip to content

fix(reactor): fix reactor initialization on CLI tools #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glevco merged 1 commit into from
Dec 28, 2023
Merged

fix(reactor): fix reactor initialization on CLI tools #906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hathor/cli/events_simulator/events_simulator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def execute(args: Namespace) -> None:
os.environ['HATHOR_CONFIG_YAML'] = UNITTESTS_SETTINGS_FILEPATH
from hathor.cli.events_simulator.event_forwarding_websocket_factory import EventForwardingWebsocketFactory
from hathor.cli.events_simulator.scenario import Scenario
from hathor.reactor import get_global_reactor
from hathor.reactor import initialize_global_reactor
from hathor.simulator import Simulator

try:
Expand All @@ -53,7 +53,7 @@ def execute(args: Namespace) -> None:
possible_scenarios = [scenario.name for scenario in Scenario]
raise ValueError(f'Invalid scenario "{args.scenario}". Choose one of {possible_scenarios}') from e

reactor = get_global_reactor()
reactor = initialize_global_reactor()
log = logger.new()
simulator = Simulator(args.seed)
simulator.start()
Expand Down
4 changes: 2 additions & 2 deletions hathor/cli/stratum_mining.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def create_parser() -> ArgumentParser:

def execute(args: Namespace) -> None:
from hathor.crypto.util import decode_address
from hathor.reactor import get_global_reactor
from hathor.reactor import initialize_global_reactor
from hathor.stratum import StratumClient
from hathor.wallet.exceptions import InvalidAddress

Expand All @@ -43,7 +43,7 @@ def execute(args: Namespace) -> None:
print('The given address is invalid')
sys.exit(-1)

reactor = get_global_reactor()
reactor = initialize_global_reactor()
miner = StratumClient(proc_count=args.nproc, address=address, reactor=reactor)
miner.start()
point = TCP4ClientEndpoint(reactor, args.host, args.port)
Expand Down