feat(feature-activation): configure new NOP features on testnet#879
Merged
feat(feature-activation): configure new NOP features on testnet#879
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #879 +/- ##
==========================================
+ Coverage 85.29% 85.36% +0.06%
==========================================
Files 281 281
Lines 22364 22367 +3
Branches 3388 3388
==========================================
+ Hits 19075 19093 +18
+ Misses 2610 2595 -15
Partials 679 679 ☔ View full report in Codecov by Sentry. |
jansegre
approved these changes
Nov 23, 2023
msbrogli
approved these changes
Nov 23, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Configure the new NOP features in testnet to restart the Phased Testing.
The start height is 3.386.880, which is 38.000 blocks from the current best height in testnet. This is equivalent to 13 days, meaning the Phase Testing should start around Dec 6th. We need to deploy this code before that.
Acceptance Criteria
testnet.ymlandtestnet.py.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged