Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #876 +/- ##
==========================================
- Coverage 85.30% 85.21% -0.09%
==========================================
Files 281 281
Lines 22364 22372 +8
Branches 3388 3387 -1
==========================================
- Hits 19077 19065 -12
- Misses 2603 2619 +16
- Partials 684 688 +4 ☔ View full report in Codecov by Sentry. |
cafb96e to
21bfe91
Compare
7cb5b15 to
df903c3
Compare
msbrogli
approved these changes
Nov 24, 2023
jansegre
approved these changes
Nov 24, 2023
df903c3 to
59bdf45
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Change the ordering of
VERTEX_METADATA_CHANGEDevents. Before it was ordered by descending timestamp, which is a reverse topological ordering. We now sort by voided txs first, and untie by descending timestamp. This aids Reliable Integration client implementation.Acceptance Criteria
UNVOIDED_TRANSACTIONevent simulator scenario and respective test.include_metadataparameter inBaseTransaction.clone().Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged