feat(sysctl): add controls for enabling/disabling sync versions#869
Merged
feat(sysctl): add controls for enabling/disabling sync versions#869
Conversation
msbrogli
approved these changes
Nov 10, 2023
glevco
approved these changes
Nov 10, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If during the sync-v2 trial period we end up in a situation where sync-v2 fails to advance, working around this would require at the very least a node restart, but usually in practice a re-deploy. With this change it is now possible to enable sync-v1 and disable sync-v2 in runtime without restarting a node.
Acceptance Criteria
p2p.available_sync_versions(readonly) andp2p.enabled_sync_versions(read-write)Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged