refactor(verification): remove token info duplication [part 9/9]

[glevco]

Depends on #837

Motivation

Remove unnecessary duplicate calculation of token_info, as requested in this comment: #831 (comment).

Acceptance Criteria

• Remove TransactionVerifier.verify_sum() as it only called verify_authorities_and_deposit().
• Change TokenCreationTransactionVerifier.verify_minted_tokens() to receive a token_dict.
• Change VerificationService._verify_tx() and _verify_token_creation_tx() to prevent duplicate calculation of the token_dict.

Checklist

• If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db91e96) 85.25% compared to head (4680b0d) 85.31%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
+ Coverage   85.25%   85.31%   +0.06%     
==========================================
  Files         283      283              
  Lines       22415    22416       +1     
  Branches     3397     3397              
==========================================
+ Hits        19110    19125      +15     
+ Misses       2616     2605      -11     
+ Partials      689      686       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The base branch was changed.