refactor(p2p): have two internal tiers for sync: available and enabled#867
Merged
refactor(p2p): have two internal tiers for sync: available and enabled#867
Conversation
587180c to
4bbb6b7
Compare
msbrogli
previously approved these changes
Nov 10, 2023
glevco
previously approved these changes
Nov 10, 2023
4bbb6b7 to
830da1e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #867 +/- ##
==========================================
- Coverage 85.41% 85.32% -0.10%
==========================================
Files 281 281
Lines 22274 22306 +32
Branches 3375 3380 +5
==========================================
+ Hits 19026 19032 +6
- Misses 2581 2594 +13
- Partials 667 680 +13
☔ View full report in Codecov by Sentry. |
msbrogli
approved these changes
Nov 10, 2023
glevco
approved these changes
Nov 10, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR refactors internal code in order to make it easier to add sysctl controls for enabling and disabling specific sync versions.
Acceptance Criteria
ConnectionsManagerso that instead of havingenable_sync_v1andenable_sync_v2it has "available sync versions" and "enabled sync versions". A sync version being available means that it can be enabled or disabled at runtime. This distinction is useful because there are init-time requirements for making specific sync versions available and it is practical to deal with these separately from whether a specific sync version is enabled or not.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged