refactor(sync): remove legacy sync-v1.0#864
Merged
Conversation
f365880 to
50edd9e
Compare
50edd9e to
07f34ee
Compare
msbrogli
approved these changes
Nov 10, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #864 +/- ##
==========================================
- Coverage 85.42% 85.38% -0.05%
==========================================
Files 282 281 -1
Lines 22270 22231 -39
Branches 3367 3364 -3
==========================================
- Hits 19025 18981 -44
Misses 2583 2583
- Partials 662 667 +5
☔ View full report in Codecov by Sentry. |
glevco
approved these changes
Nov 10, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It's been legacy for a while and we haven't even deployed any nodes with 1.0 support for a while.
Acceptance Criteria
SyncVersion.V1_1(with value'v1.1') is used and neverSyncVersion.V1(with value'v1') which could previously be used depending on a cli argument--x-enable-legacy-sync-v1_0argument is removed, nothing else changes for the CLIChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged