Skip to content

refactor(verification): implement verification context#862

Closed
glevco wants to merge 4 commits intorefactor/verification-dependencies-part-2from
refactor/verification-context
Closed

refactor(verification): implement verification context#862
glevco wants to merge 4 commits intorefactor/verification-dependencies-part-2from
refactor/verification-context

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Nov 9, 2023

Depends on #904

Motivation

What was the motivation for the changes in this PR?

Acceptance Criteria

  • Include here all things that this PR should solve

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco added the refactor label Nov 9, 2023
@glevco glevco self-assigned this Nov 9, 2023
@glevco glevco force-pushed the refactor/verification-dependencies branch from 8c08e8c to 581399b Compare November 9, 2023 19:25
@glevco glevco force-pushed the refactor/verification-context branch from a07c6ca to 830a952 Compare November 9, 2023 19:27
@glevco glevco force-pushed the refactor/verification-dependencies branch from 581399b to a89dde8 Compare November 9, 2023 19:28
@glevco glevco force-pushed the refactor/verification-context branch from 830a952 to bbc5e13 Compare November 9, 2023 19:28
@glevco glevco force-pushed the refactor/verification-dependencies branch 2 times, most recently from 2da64c0 to 492f364 Compare November 9, 2023 20:12
@codecov
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9153b4) 85.35% compared to head (a21b12a) 85.38%.

Additional details and impacted files
@@                              Coverage Diff                              @@
##           refactor/verification-dependencies-part-2     #862      +/-   ##
=============================================================================
+ Coverage                                      85.35%   85.38%   +0.02%     
=============================================================================
  Files                                            287      288       +1     
  Lines                                          22488    22527      +39     
  Branches                                        3390     3404      +14     
=============================================================================
+ Hits                                           19195    19234      +39     
  Misses                                          2617     2617              
  Partials                                         676      676              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the refactor/verification-context branch 2 times, most recently from d284d4b to 3ac5a1f Compare November 9, 2023 21:35
@glevco glevco force-pushed the refactor/verification-dependencies branch 5 times, most recently from ff67e63 to 2473e1b Compare December 19, 2023 20:20
@glevco glevco force-pushed the refactor/verification-context branch from 3ac5a1f to 1658581 Compare December 19, 2023 22:02
@glevco glevco force-pushed the refactor/verification-dependencies branch 2 times, most recently from b5266b2 to 774ccf4 Compare December 22, 2023 20:22
@glevco glevco force-pushed the refactor/verification-dependencies branch from 774ccf4 to 7aa9e72 Compare December 22, 2023 21:18
@glevco glevco force-pushed the refactor/verification-context branch from 1658581 to f6fa2bd Compare December 22, 2023 21:59
@glevco glevco changed the base branch from refactor/verification-dependencies to refactor/verification-dependencies-part-2 December 22, 2023 22:01
@glevco glevco force-pushed the refactor/verification-dependencies-part-2 branch 2 times, most recently from fc1e6c0 to 1a93e95 Compare December 23, 2023 02:14
@glevco
Copy link
Contributor Author

glevco commented Dec 23, 2023

Closing this as it won't be necessary after some refactors related to Multiprocess Verification.

@glevco glevco closed this Dec 23, 2023
@glevco glevco deleted the refactor/verification-context branch December 23, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant