feat(sync-v2): Always relay vertices in real-time if the peer requested it#861
Merged
feat(sync-v2): Always relay vertices in real-time if the peer requested it#861
Conversation
glevco
approved these changes
Nov 9, 2023
3a94d07 to
b6cab8b
Compare
jansegre
approved these changes
Nov 9, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #861 +/- ##
==========================================
- Coverage 85.33% 85.31% -0.03%
==========================================
Files 282 282
Lines 22269 22267 -2
Branches 3367 3366 -1
==========================================
- Hits 19003 18996 -7
- Misses 2597 2602 +5
Partials 669 669
☔ View full report in Codecov by Sentry. |
b6cab8b to
d5be7b9
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The logic to decide whether we would relay real-time vertices to peer used by in the sender. But now we moved it to the client, which means each peer can independently decide whether they want to receive real-time vertices or not.
This PR removes an outdated condition that was preventing the peer to decide.
Acceptance Criteria
is_synced()verification ofsend_tx_to_peer_if_possible()Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged