Conversation
glevco
approved these changes
Nov 9, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #856 +/- ##
==========================================
- Coverage 85.43% 85.40% -0.03%
==========================================
Files 282 282
Lines 22253 22243 -10
Branches 3363 3361 -2
==========================================
- Hits 19011 18996 -15
- Misses 2576 2579 +3
- Partials 666 668 +2
☔ View full report in Codecov by Sentry. |
b0c394a to
85683d6
Compare
jansegre
approved these changes
Nov 9, 2023
85683d6 to
382cc38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
first_blockissue caused us to not stop the streaming of transactions when an unexpected vertex is received. But it not necessary to do it anymore because the streamer server is handling this case.Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged