Merged
Conversation
jansegre
approved these changes
Nov 9, 2023
glevco
approved these changes
Nov 9, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #854 +/- ##
==========================================
- Coverage 85.50% 85.33% -0.18%
==========================================
Files 282 282
Lines 22242 22247 +5
Branches 3361 3363 +2
==========================================
- Hits 19018 18984 -34
- Misses 2562 2595 +33
- Partials 662 668 +6
☔ View full report in Codecov by Sentry. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After running our latest QA, we noticed that the sync-v2 logging can be improved in a way that we don't get too many duplicated log messages but got enough messages to debug an issue.
Acceptance Criteria
_HeightInfo.__str__()because it is used by the log json serializer.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged