fix(verification): avoid validation downgrade by not running it twice#853
Merged
fix(verification): avoid validation downgrade by not running it twice#853
Conversation
glevco
previously approved these changes
Nov 9, 2023
c118b40 to
9f2a422
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #853 +/- ##
==========================================
- Coverage 85.36% 85.32% -0.05%
==========================================
Files 282 282
Lines 22267 22271 +4
Branches 3366 3368 +2
==========================================
- Hits 19009 19003 -6
- Misses 2592 2599 +7
- Partials 666 669 +3
☔ View full report in Codecov by Sentry. |
msbrogli
approved these changes
Nov 9, 2023
9f2a422 to
27b07b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In new sync-v2 sync flow, a node can receive a transaction that it already has, but the node might run
validate_basicbefore processing the transaction. Before this PR runningvalidate_basicon an existing and fully verified transaction would run the validation and downgrade the validation state from FULL to BASIC.Acceptance Criteria
validate_basicto skip the validation if the given transaction has already been validated at the same or higher validation level.Adjust bothRemoved from this PR because it affects other tests which require changes tovalidate_fullto skip the validation if the given transaction has already been validated at the same or higher validation level.HathorManager.on_new_txfor a proper fix and this isn't needed for anything in sync-v2Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged