Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #846 +/- ##
=======================================
Coverage 85.01% 85.01%
=======================================
Files 271 271
Lines 22368 22362 -6
Branches 3420 3416 -4
=======================================
- Hits 19017 19012 -5
+ Misses 2675 2674 -1
Partials 676 676 ☔ View full report in Codecov by Sentry. |
jansegre
approved these changes
Nov 3, 2023
Member
jansegre
left a comment
There was a problem hiding this comment.
Makes sense. I set up vim to store temp files in a dedicated dir, so I never experienced this.
glevco
approved these changes
Nov 3, 2023
50a18a9 to
b0642e2
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If a file is open in vim, this skip wrongfully fails because the
.swpfile concatenate lines using a custom separator so the whole file is considered as in one line.Acceptance Criteria
-Ioption to skip binary files.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged