Conversation
681e60d to
30cc9af
Compare
glevco
reviewed
Nov 1, 2023
438a81a to
67d5ce4
Compare
b547f76 to
708b5a8
Compare
glevco
previously approved these changes
Nov 3, 2023
67d5ce4 to
98121c4
Compare
708b5a8 to
38158b6
Compare
glevco
previously approved these changes
Nov 3, 2023
38158b6 to
92bde24
Compare
jansegre
previously approved these changes
Nov 3, 2023
…ting next syncing cycle
92bde24 to
4b04c9c
Compare
jansegre
approved these changes
Nov 3, 2023
glevco
approved these changes
Nov 3, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Previously, the
_run_sync()method checked for ongoing mempool syncs or open streamings to prevent concurrent cycle runs. Despite the presence of the_is_running: boolflag, it was prematurely marked asfalsedue to mempool syncs and streamings returning at the start, not the end, of their execution. This led to complexity and potential errors in_run_sync(). This PR streamlines this process for better clarity and reliability.Acceptance Criteria
_deferred_blockchain_streamingwhen we request the peer to open a block streaming._deferred_blockchain_streamingwhen the streaming ends._deferred_transactions_streamingwhen we request the peer to open a transactions streaming._deferred_transactions_streamingwhen the streaming ends.run_sync_transactions()to wait for its streaming to end.run_sync_blocks()to wait for its streaming to end.mempool_manager.run()to return a deferred that is resolved when the execution is complete.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged