Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #844 +/- ##
===========================================
+ Coverage 0 85.21% +85.21%
===========================================
Files 0 285 +285
Lines 0 22370 +22370
Branches 0 3371 +3371
===========================================
+ Hits 0 19063 +19063
- Misses 0 2634 +2634
- Partials 0 673 +673 ☔ View full report in Codecov by Sentry. |
e7b35d6 to
bf1e946
Compare
bf1e946 to
f685a4e
Compare
f685a4e to
3c45fb1
Compare
3c45fb1 to
688b9a7
Compare
glevco
previously approved these changes
Jan 12, 2024
msbrogli
approved these changes
Jan 12, 2024
688b9a7 to
c2dfc54
Compare
msbrogli
previously approved these changes
Jan 12, 2024
c85ef3e to
2410024
Compare
c2dfc54 to
406a412
Compare
The base branch was changed.
406a412 to
8e579c4
Compare
glevco
approved these changes
Jan 15, 2024
msbrogli
approved these changes
Jan 15, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This Python release is out, there may not be specific features motivating the upgrade, but it's generally good to ensure everything is working on that version before we decide to use it.
Acceptance Criteria
pyproject.toml) or indirectly (poetry.lock) as neededChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged