feat(sync-v2): Improve sync-v2 reliability#843
Merged
Conversation
aa8f709 to
3c04ac0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #843 +/- ##
==========================================
+ Coverage 85.01% 85.04% +0.02%
==========================================
Files 271 271
Lines 22368 22368
Branches 3420 3418 -2
==========================================
+ Hits 19017 19022 +5
+ Misses 2675 2671 -4
+ Partials 676 675 -1
☔ View full report in Codecov by Sentry. |
5c9fed6 to
f5d6e6b
Compare
9092163 to
438a81a
Compare
glevco
previously approved these changes
Nov 1, 2023
jansegre
previously approved these changes
Nov 1, 2023
dcb0e77 to
c47f06e
Compare
438a81a to
67d5ce4
Compare
The base branch was changed.
glevco
approved these changes
Nov 3, 2023
67d5ce4 to
98121c4
Compare
jansegre
approved these changes
Nov 3, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The previous organization of responsibilities within sync-v2's internal methods was ambiguous. This Pull Request enhances the clarity by:
This refactoring aims to streamline the process, reduce potential errors, and make the codebase more maintainable.
Acceptance Criteria
find_best_common_block()to just find the best common block. So it will not set sync state and update relay anymore.run_sync_blocks()method.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged