fix(sync-v2): Fix streamer sending more blocks than expected#839
Merged
fix(sync-v2): Fix streamer sending more blocks than expected#839
Conversation
msbrogli
force-pushed
the
refactor/sync-v2-agent
branch
from
fa66c90 to
897e743
Compare
msbrogli
force-pushed
the
fix/sync-v2-exceeding-max-blocks
branch
from
cf82fe1 to
4c9500e
Compare
msbrogli
force-pushed
the
refactor/sync-v2-agent
branch
3 times, most recently
from
ab90d2e to
4e38833
Compare
msbrogli
force-pushed
the
fix/sync-v2-exceeding-max-blocks
branch
from
4c9500e to
c5be132
Compare
msbrogli
force-pushed
the
refactor/sync-v2-agent
branch
from
4e38833 to
d65b21f
Compare
msbrogli
force-pushed
the
fix/sync-v2-exceeding-max-blocks
branch
from
c5be132 to
4642771
Compare
msbrogli
force-pushed
the
fix/sync-v2-exceeding-max-blocks
branch
from
4642771 to
a27e9a4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #839 +/- ##
==========================================
+ Coverage 84.55% 84.57% +0.01%
==========================================
Files 270 270
Lines 22290 22291 +1
Branches 3406 3406
==========================================
+ Hits 18848 18853 +5
+ Misses 2769 2768 -1
+ Partials 673 670 -3
☔ View full report in Codecov by Sentry. |
jansegre
approved these changes
Oct 27, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Sync-v2 streamer was sending more blocks than expected. Then, the peer was closing the connection causing tests to randomly fail. I haven't confirmed yet but I think this edge case happens when a reorg occurs during the sync.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged