fix(feature-activation): add missing metadata migration#828
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #828 +/- ##
==========================================
- Coverage 84.63% 84.62% -0.01%
==========================================
Files 270 271 +1
Lines 22290 22306 +16
Branches 3404 3406 +2
==========================================
+ Hits 18865 18877 +12
- Misses 2757 2762 +5
+ Partials 668 667 -1
☔ View full report in Codecov by Sentry. |
msbrogli
requested changes
Oct 27, 2023
msbrogli
approved these changes
Oct 27, 2023
jansegre
approved these changes
Oct 27, 2023
366e6ae to
559d250
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
During the latest release, we noticed that full node initialization could fail depending on the snapshot state (only on testnet). This was caused by a missing migration on the new Feature Activation metadata attribute.
Acceptance Criteria
BitSignalingService.start()togenerate_initial_logs()and add docstring. Also move call to after migrations are applied inHathorManager.add_feature_activation_bit_counts_metadatamigration.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged