fix(mining): Wrong timestamp sent to _make_block_template#823
Merged
fix(mining): Wrong timestamp sent to _make_block_template#823
Conversation
glevco
approved these changes
Oct 20, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #823 +/- ##
==========================================
- Coverage 84.55% 84.51% -0.05%
==========================================
Files 269 269
Lines 22234 22234
Branches 3397 3397
==========================================
- Hits 18800 18791 -9
- Misses 2765 2770 +5
- Partials 669 673 +4
☔ View full report in Codecov by Sentry. |
jansegre
approved these changes
Oct 23, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR #822 was not enough to fix the flaky tests because the caller of
_make_block_template()was sending the wrongcurrent_timestamp.Acceptance Criteria
current_timestampinHathorManager.make_block_template().Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged