Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #821 +/- ##
==========================================
- Coverage 84.60% 84.55% -0.05%
==========================================
Files 269 269
Lines 22223 22223
Branches 3398 3398
==========================================
- Hits 18802 18791 -11
- Misses 2755 2762 +7
- Partials 666 670 +4 ☔ View full report in Codecov by Sentry. |
msbrogli
approved these changes
Oct 20, 2023
jansegre
approved these changes
Oct 20, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
test_non_signaling_features_warning()test was flaky. This PR tries to fix this. Before, it usedcapture_logs()fromstructlog. I believe the flakiness reason was related to that (maybe because it's not thread-safe).Acceptance Criteria
test_non_signaling_features_warning()to use a standard mock instead of capturing logs.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged