Conversation
msbrogli
force-pushed
the
fix/sysctl-deserializer
branch
2 times, most recently
from
3e4a7bb to
a338df9
Compare
jansegre
previously approved these changes
Oct 19, 2023
msbrogli
force-pushed
the
fix/sysctl-deserializer
branch
from
a338df9 to
3fcd054
Compare
jansegre
approved these changes
Oct 19, 2023
msbrogli
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #820 +/- ##
==========================================
- Coverage 84.53% 84.48% -0.05%
==========================================
Files 266 269 +3
Lines 22131 22223 +92
Branches 3380 3396 +16
==========================================
+ Hits 18709 18776 +67
- Misses 2757 2773 +16
- Partials 665 674 +9
☔ View full report in Codecov by Sentry. |
alexruzenhack
approved these changes
Oct 20, 2023
1 task
msbrogli
force-pushed
the
fix/sysctl-deserializer
branch
from
3fcd054 to
9cee806
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
SysctlRunner.deserialize()leveraging the JSON-deserializer.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged