Conversation
luislhl
previously approved these changes
Oct 6, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #806 +/- ##
=======================================
Coverage 84.65% 84.66%
=======================================
Files 264 264
Lines 22034 22034
Branches 3369 3369
=======================================
+ Hits 18652 18654 +2
+ Misses 2726 2725 -1
+ Partials 656 655 -1
☔ View full report in Codecov by Sentry. |
msbrogli
requested changes
Oct 9, 2023
ef89236 to
bd854c1
Compare
msbrogli
previously approved these changes
Oct 9, 2023
luislhl
previously approved these changes
Oct 10, 2023
luislhl
approved these changes
Oct 10, 2023
fd3c1ff to
e2db317
Compare
e2db317 to
67085e3
Compare
msbrogli
approved these changes
Oct 11, 2023
This was referenced Oct 17, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
/push_txAPI currently generates alerts when it fails. It should simply log the reason, but not generate an alert. For more info, read https://github.com/HathorNetwork/on-call-incidents/issues/97.Acceptance Criteria
exc_infoby an human-readable message from the warning logged by/push_tx. By removing the "Traceback" from the log, an alert is not fired anymore.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged