refactor(cpu-mining): create CpuMiningService#803
Merged
Conversation
1 task
cf8df1d to
75f9964
Compare
4f8296a to
0ae446e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #803 +/- ##
==========================================
- Coverage 85.09% 85.05% -0.05%
==========================================
Files 275 276 +1
Lines 22516 22514 -2
Branches 3434 3430 -4
==========================================
- Hits 19161 19149 -12
- Misses 2672 2678 +6
- Partials 683 687 +4
☔ View full report in Codecov by Sentry. |
75f9964 to
fd22533
Compare
0348cc0 to
dc7d9de
Compare
jansegre
previously approved these changes
Oct 10, 2023
msbrogli
previously approved these changes
Oct 18, 2023
fd22533 to
88c0162
Compare
dc7d9de to
639fd12
Compare
88c0162 to
3926fa5
Compare
639fd12 to
0a780e9
Compare
Base automatically changed from
refactor/simulator-patches/daa-test-mode
to
master
November 3, 2023 22:34
The base branch was changed.
0a780e9 to
0ad3797
Compare
jansegre
previously approved these changes
Nov 3, 2023
0ad3797 to
9cbb87e
Compare
jansegre
approved these changes
Nov 6, 2023
msbrogli
approved these changes
Nov 6, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #802
Motivation
This PR refactors the
BaseTransaction.resolve()method, allowing its simulator patch to be removed.Acceptance Criteria
resolve()andstart_mining()methods fromBaseTransactionand fromTokenCreationTransaction, moving them to the newCpuMiningServiceclass. Code logic should not be changed, except for the addition of theTokenCreationTransactioncase.CpuMiningServicetoHathorManager, and updateBuilderandCliBuilderaccordingly.simulator/verification.pytosimulator/patches.py, adding the newSimulatorCpuMiningServiceclass that overridesresolve().Simulator, that now only uses injected customizations.resolve()andstart_mining().Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged