Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #772 +/- ##
==========================================
+ Coverage 85.16% 85.22% +0.06%
==========================================
Files 284 285 +1
Lines 22576 22655 +79
Branches 3430 3444 +14
==========================================
+ Hits 19226 19308 +82
Misses 2667 2667
+ Partials 683 680 -3
☔ View full report in Codecov by Sentry. |
eda0545 to
e672226
Compare
jansegre
previously approved these changes
Sep 19, 2023
msbrogli
requested changes
Sep 19, 2023
f383165 to
2dbc6b3
Compare
85c5ae3 to
7e2d1af
Compare
Contributor
Author
@jansegre both done! |
7e2d1af to
fc27813
Compare
fc27813 to
6bd92a1
Compare
jansegre
previously approved these changes
Sep 22, 2023
msbrogli
previously approved these changes
Sep 22, 2023
050373e to
4c436e3
Compare
4c436e3 to
c2e4593
Compare
jansegre
previously approved these changes
Sep 27, 2023
1981890 to
1d4c04c
Compare
msbrogli
previously approved these changes
Sep 28, 2023
1d4c04c to
f093a77
Compare
Contributor
Author
|
Converted to draft as we wait other PRs to be merged before this one. |
f093a77 to
cacba12
Compare
cacba12 to
5a38b60
Compare
msbrogli
approved these changes
Nov 7, 2023
jansegre
approved these changes
Nov 7, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The events simulator CLI tool was using some functions defined in the
testsmodule, which is not copied to the Docker image. To make the tool available via Docker, those functions must be moved to another module.Acceptance Criteria
testsmodule toutils/simulatormoduletestsare not imported inhathorChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged