refactor: move get settings [part 2]

[glevco]

Depends on #768

Motivation

Please read the description on #768, this PR is just a follow-up part.

Acceptance Criteria

• Remove some usages of HathorSettings() from the module level and move it to inside functions/methods
  • For functions, the function just calls the new get_settings()
  • For classes we set self._settings = get_settings() in the class' __init__(), and update all methods to use that new attribute

Checklist

• If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

[jansegre]

If this refactor is complete and there aren't any old import patterns I recommend adding a linter to extras/custom_checks.sh to prevent us from accidentally using a deprecated pattern.

NOTE: GitHub seems unstable (I've got a 500 error a few times trying to add this comment to an approval)

[glevco]

If this refactor is complete and there aren't any old import patterns I recommend adding a linter to extras/custom_checks.sh to prevent us from accidentally using a deprecated pattern.

That's a good idea, I'll make sure to do that, but it can't be done yet. There are still a lot of places to change, it'll take some other PRs to kill all usages. I'm beginning with the easy ones, but then there will be a batch of "hard" ones that have to change a bit more of logic (for example, code that uses settings to define default values for classes, etc)

[codecov]

Codecov Report

Patch coverage: 90.62% and project coverage change: -0.05% ⚠️

Comparison is base (dbeaa9e) 84.75% compared to head (d8d5435) 84.71%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #769      +/-   ##
==========================================
- Coverage   84.75%   84.71%   -0.05%     
==========================================
  Files         259      259              
  Lines       21933    21931       -2     
  Branches     2964     2964              
==========================================
- Hits        18590    18579      -11     
- Misses       2700     2706       +6     
- Partials      643      646       +3     

Files Changed	Coverage Δ
hathor/consensus/context.py	100.00% <ø> (ø)
hathor/indexes/rocksdb_height_index.py	94.11% <ø> (-0.12%)	⬇️
hathor/merged_mining/coordinator.py	34.02% <ø> (-0.19%)	⬇️
hathor/mining/ws.py	50.00% <ø> (-0.71%)	⬇️
hathor/consensus/block_consensus.py	94.36% <57.14%> (ø)
hathor/graphviz.py	77.02% <66.66%> (ø)
hathor/consensus/consensus.py	97.89% <83.33%> (ø)
hathor/consensus/transaction_consensus.py	96.11% <88.88%> (ø)
hathor/builder/builder.py	91.79% <100.00%> (ø)
hathor/builder/cli_builder.py	74.22% <100.00%> (-0.14%)	⬇️
... and 7 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The base branch was changed.