feat(reliable-integration): implement stream ID#766
Merged
Conversation
jansegre
previously approved these changes
Sep 4, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #766 +/- ##
=======================================
Coverage 84.74% 84.74%
=======================================
Files 259 259
Lines 21912 21940 +28
Branches 2963 2964 +1
=======================================
+ Hits 18570 18594 +24
- Misses 2696 2701 +5
+ Partials 646 645 -1
☔ View full report in Codecov by Sentry. |
msbrogli
previously approved these changes
Sep 6, 2023
c5172f0 to
cc35384
Compare
f5f04b0 to
728f1e7
Compare
Base automatically changed from
feat/reliable-integration/decoded-outputs
to
master
September 11, 2023 01:17
The base branch was changed.
8a4d334 to
1a977f0
Compare
msbrogli
approved these changes
Sep 11, 2023
jansegre
approved these changes
Sep 11, 2023
1a977f0 to
7108be4
Compare
This was referenced Oct 17, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #763
Motivation
Implement an event stream ID so every time the event database is reset, a new ID is generated. This makes it easy for the client to know if he has to reprocess events from the beginning.
Acceptance Criteria
EventManagersave_stream_id()andget_stream_id()methods toEventStorageand its implementationsEventStorage.reset_events()Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged