Skip to content

feat(feature-activation): configure NOP features on testnet#761

Merged
jansegre merged 1 commit intomasterfrom
feat/feature-activation/configure-nop-features
Aug 28, 2023
Merged

feat(feature-activation): configure NOP features on testnet#761
jansegre merged 1 commit intomasterfrom
feat/feature-activation/configure-nop-features

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Aug 25, 2023

Depends on #760

Motivation

Configure the NOP features in testnet according to the definition in the Phased Testing RFC.

Acceptance Criteria

  • Configure NOP features in testnet.yml and testnet.py

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Aug 25, 2023
jansegre
jansegre previously approved these changes Aug 25, 2023
msbrogli
msbrogli previously approved these changes Aug 25, 2023
@glevco glevco force-pushed the feat/feature-activation/logging-nop-features branch from a5c50db to 2f70ef1 Compare August 25, 2023 22:48
@glevco glevco force-pushed the feat/feature-activation/configure-nop-features branch from b0822f3 to 29d9ec3 Compare August 25, 2023 22:48
@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #761 (29d9ec3) into master (5fbcd4e) will decrease coverage by 0.03%.
Report is 7 commits behind head on master.
The diff coverage is 59.09%.

❗ Current head 29d9ec3 differs from pull request most recent head fd5941d. Consider uploading reports for the commit fd5941d to get more accurate results

@@            Coverage Diff             @@
##           master     #761      +/-   ##
==========================================
- Coverage   84.73%   84.70%   -0.03%     
==========================================
  Files         253      252       -1     
  Lines       21801    21801              
  Branches     2953     2954       +1     
==========================================
- Hits        18473    18467       -6     
- Misses       2684     2692       +8     
+ Partials      644      642       -2     
Files Changed Coverage Δ
hathor/builder/cli_builder.py 74.48% <ø> (ø)
hathor/manager.py 81.83% <43.75%> (-0.94%) ⬇️
hathor/builder/builder.py 91.79% <100.00%> (+0.27%) ⬆️
hathor/conf/testnet.py 100.00% <100.00%> (ø)
hathor/feature_activation/settings.py 100.00% <100.00%> (ø)
hathor/version.py 85.29% <100.00%> (ø)

... and 8 files with indirect coverage changes

Base automatically changed from feat/feature-activation/logging-nop-features to master August 28, 2023 16:49
@msbrogli msbrogli dismissed stale reviews from jansegre and themself August 28, 2023 16:49

The base branch was changed.

@glevco glevco marked this pull request as ready for review August 28, 2023 16:50
@glevco glevco force-pushed the feat/feature-activation/configure-nop-features branch from 29d9ec3 to fd5941d Compare August 28, 2023 18:06
@jansegre jansegre merged commit 376c55b into master Aug 28, 2023
@jansegre jansegre deleted the feat/feature-activation/configure-nop-features branch August 28, 2023 20:30
This was referenced Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants