Skip to content

chore: add deprecation warning for Python 3.9 #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jansegre merged 1 commit into from
Aug 25, 2023
Merged

chore: add deprecation warning for Python 3.9 #759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions hathor/cli/run_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,11 +310,14 @@ def check_unsafe_arguments(self) -> None:
sys.exit(-1)

def check_python_version(self) -> None:
MIN_VER = (3, 8)
RECOMMENDED_VER = (3, 9)
# comments to help grep's
MIN_VER = (3, 9) # Python-3.9
MIN_STABLE = (3, 10) # Python-3.10
RECOMMENDED_VER = (3, 10) # Python-3.10
cur = sys.version_info
min_pretty = '.'.join(map(str, MIN_VER))
cur_pretty = '.'.join(map(str, cur))
min_pretty = '.'.join(map(str, MIN_VER))
min_stable_pretty = '.'.join(map(str, MIN_STABLE))
recommended_pretty = '.'.join(map(str, RECOMMENDED_VER))
if cur < MIN_VER:
self.log.critical('\n'.join([
Expand All @@ -327,6 +330,17 @@ def check_python_version(self) -> None:
'',
]))
sys.exit(-1)
elif cur < MIN_STABLE:
self.log.warning('\n'.join([
'',
'********************************************************',
f'The detected Python version {cur_pretty} is deprecated and support for it will be removed in the'
' next release.',
f'The minimum supported Python version will be {min_stable_pretty}',
f'The recommended Python version is {recommended_pretty}',
'********************************************************',
'',
]))

def __init__(self, *, argv=None):
self.log = logger.new()
Expand Down