refactor: use Hathor simulator on events simulator CLI#758
Merged
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #758 +/- ##
==========================================
- Coverage 84.78% 84.72% -0.07%
==========================================
Files 259 259
Lines 21900 21900
Branches 2960 2960
==========================================
- Hits 18569 18554 -15
- Misses 2687 2702 +15
Partials 644 644 ☔ View full report in Codecov by Sentry. |
msbrogli
approved these changes
Aug 28, 2023
glevco
force-pushed
the
refactor/event-simulator-cli
branch
2 times, most recently
from
9f518c5 to
8c1b925
Compare
glevco
force-pushed
the
refactor/event-simulator-cli
branch
from
8c1b925 to
50deb84
Compare
jansegre
approved these changes
Sep 1, 2023
This was referenced Oct 17, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Both the Events Simulator CLI tool and the events simulator scenarios tests were very similar (in fact, they were doing the same thing), using a hardcoded event list as fixtures. The CLI tool can simply use the
Simulatorclass to actually generate the events, like it's done in the unit tests.Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged