fix(tests): make simulator test not flaky on sync-v2#750
Merged
Conversation
jansegre
force-pushed
the
fix/sync-v2-flaky-tests
branch
3 times, most recently
from
502e6e9 to
96ad7d0
Compare
jansegre
force-pushed
the
fix/sync-v2-flaky-tests
branch
from
96ad7d0 to
480cbe1
Compare
msbrogli
approved these changes
Aug 21, 2023
glevco
approved these changes
Aug 22, 2023
This was referenced Aug 29, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This test became very flaky after the latest changes on sync-v2.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged