fix(event-queue): improve memory usage during the load phase#744
Merged
fix(event-queue): improve memory usage during the load phase#744
Conversation
22ef998 to
6ab0e74
Compare
msbrogli
previously approved these changes
Aug 3, 2023
jansegre
approved these changes
Aug 3, 2023
Codecov Report
@@ Coverage Diff @@
## master #744 +/- ##
==========================================
- Coverage 84.56% 84.51% -0.05%
==========================================
Files 252 253 +1
Lines 21688 21705 +17
Branches 2937 2941 +4
==========================================
+ Hits 18341 18345 +4
- Misses 2709 2719 +10
- Partials 638 641 +3
|
2fb77fc to
a909ab2
Compare
msbrogli
approved these changes
Aug 3, 2023
This was referenced Aug 29, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The previous code was consuming too much memory when loading events from an existing database.
Acceptance Criteria
batch_iterator()utils function that converts an iterator of items into an iterator of batches.EventManager.handle_load_phase_vertices()so it saves events to RocksDB in write batches of 10.000 events instead of a single batch with all events.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged