refactor(event-queue): improve event ordering#738
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #738 +/- ##
==========================================
+ Coverage 84.55% 84.57% +0.01%
==========================================
Files 252 252
Lines 21686 21688 +2
Branches 2936 2937 +1
==========================================
+ Hits 18337 18342 +5
+ Misses 2712 2710 -2
+ Partials 637 636 -1
|
msbrogli
approved these changes
Jul 29, 2023
jansegre
approved these changes
Jul 31, 2023
This was referenced Aug 29, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Reliable integration events could be generated in a non-consistent order on different runs, caused by a for-loop on an unordered
setin the consensus. Although this was worked-around, making the for-loop ordered improves predictability of said events and also simplifies tests.Acceptance Criteria
context.tx_affectedfor-loop in the consensus so its order is always the samezip_chunkify()utils functions as it's not used anymoreChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged