Skip to content

feat: add --sysctl-init-file as cli command option#714

Merged
jansegre merged 14 commits intomasterfrom
feat/add-optional-argument
Sep 25, 2023
Merged

feat: add --sysctl-init-file as cli command option#714
jansegre merged 14 commits intomasterfrom
feat/add-optional-argument

Conversation

@alexruzenhack
Copy link
Contributor

@alexruzenhack alexruzenhack commented Jul 23, 2023

Acceptance criteria

  • Add --sysctl-init-file CLI command option that should use the sysctl subsystem to configure the node.
  • The configuration file is a txt file with a simple key value pair scheme.

Closes:

@alexruzenhack alexruzenhack self-assigned this Jul 23, 2023
@alexruzenhack alexruzenhack force-pushed the feat/add-optional-argument branch 3 times, most recently from f6ae3ac to 72a4289 Compare July 24, 2023 13:28
@alexruzenhack alexruzenhack force-pushed the feat/add-optional-argument branch 3 times, most recently from 7822bf5 to d999e61 Compare July 26, 2023 17:46
@alexruzenhack alexruzenhack requested a review from msbrogli July 26, 2023 17:54
@alexruzenhack alexruzenhack force-pushed the feat/add-optional-argument branch 3 times, most recently from 74b2a53 to c055ba6 Compare July 26, 2023 18:18
@alexruzenhack alexruzenhack force-pushed the feat/add-optional-argument branch 2 times, most recently from a3c2d04 to 721c744 Compare July 27, 2023 00:25
@alexruzenhack alexruzenhack requested a review from msbrogli July 27, 2023 00:25
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 87.97% and project coverage change: -0.12% ⚠️

Comparison is base (dbeaa9e) 84.75% compared to head (aadaf75) 84.64%.
Report is 5 commits behind head on master.

❗ Current head aadaf75 differs from pull request most recent head f6edfcf. Consider uploading reports for the commit f6edfcf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #714      +/-   ##
==========================================
- Coverage   84.75%   84.64%   -0.12%     
==========================================
  Files         259      260       +1     
  Lines       21933    21951      +18     
  Branches     2964     2965       +1     
==========================================
- Hits        18590    18581       -9     
- Misses       2700     2722      +22     
- Partials      643      648       +5     
Files Changed Coverage Δ
hathor/builder/sysctl_builder.py 41.66% <ø> (ø)
hathor/consensus/context.py 100.00% <ø> (ø)
hathor/indexes/rocksdb_height_index.py 94.11% <ø> (-0.12%) ⬇️
hathor/merged_mining/coordinator.py 34.02% <ø> (-0.19%) ⬇️
hathor/mining/ws.py 50.00% <ø> (-0.71%) ⬇️
hathor/sysctl/runner.py 90.00% <ø> (ø)
hathor/transaction/storage/tx_allow_scope.py 92.85% <ø> (-0.48%) ⬇️
hathor/sysctl/init_file_loader.py 33.33% <33.33%> (ø)
hathor/wallet/resources/thin_wallet/send_tokens.py 68.51% <40.00%> (ø)
hathor/consensus/block_consensus.py 94.36% <57.14%> (ø)
... and 33 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msbrogli msbrogli changed the title feat: add --sysctl-config-file as cli command option feat: add --sysctl-init-file as cli command option Jul 27, 2023
@alexruzenhack alexruzenhack force-pushed the feat/add-optional-argument branch from 721c744 to 3ce4e8b Compare July 31, 2023 22:40
@alexruzenhack alexruzenhack marked this pull request as draft August 3, 2023 14:50
jansegre
jansegre previously approved these changes Aug 18, 2023
jansegre
jansegre previously approved these changes Sep 19, 2023
@alexruzenhack alexruzenhack enabled auto-merge (squash) September 25, 2023 17:14
@alexruzenhack alexruzenhack force-pushed the feat/add-optional-argument branch from aadaf75 to 7404f94 Compare September 25, 2023 17:14
@alexruzenhack alexruzenhack force-pushed the feat/add-optional-argument branch from 7404f94 to f6edfcf Compare September 25, 2023 17:17
@jansegre jansegre merged commit 8806b21 into master Sep 25, 2023
@jansegre jansegre deleted the feat/add-optional-argument branch September 25, 2023 18:05
@jansegre jansegre restored the feat/add-optional-argument branch September 25, 2023 18:06
jansegre added a commit that referenced this pull request Sep 25, 2023
feat: add --sysctl-init-file as cli command option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants