feat: add --sysctl-init-file as cli command option#714
Merged
Conversation
alexruzenhack
commented
Jul 24, 2023
alexruzenhack
commented
Jul 24, 2023
alexruzenhack
commented
Jul 24, 2023
alexruzenhack
commented
Jul 24, 2023
alexruzenhack
commented
Jul 24, 2023
alexruzenhack
commented
Jul 24, 2023
alexruzenhack
commented
Jul 24, 2023
f6ae3ac to
72a4289
Compare
msbrogli
requested changes
Jul 25, 2023
7822bf5 to
d999e61
Compare
74b2a53 to
c055ba6
Compare
msbrogli
requested changes
Jul 26, 2023
a3c2d04 to
721c744
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #714 +/- ##
==========================================
- Coverage 84.75% 84.64% -0.12%
==========================================
Files 259 260 +1
Lines 21933 21951 +18
Branches 2964 2965 +1
==========================================
- Hits 18590 18581 -9
- Misses 2700 2722 +22
- Partials 643 648 +5
☔ View full report in Codecov by Sentry. |
721c744 to
3ce4e8b
Compare
jansegre
previously approved these changes
Aug 18, 2023
jansegre
previously approved these changes
Sep 19, 2023
e64315b to
99f4b7d
Compare
99f4b7d to
aadaf75
Compare
msbrogli
approved these changes
Sep 20, 2023
jansegre
approved these changes
Sep 20, 2023
aadaf75 to
7404f94
Compare
7404f94 to
f6edfcf
Compare
jansegre
added a commit
that referenced
this pull request
Sep 25, 2023
feat: add --sysctl-init-file as cli command option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance criteria
--sysctl-init-fileCLI command option that should use the sysctl subsystem to configure the node.Closes: