fix(event-queue): fix event simulator scenario parsing#706
Merged
Conversation
glevco
force-pushed
the
fix/event-simulator-scenario
branch
from
7c93dd3 to
0a7cb85
Compare
glevco
force-pushed
the
fix/event-simulator-scenario
branch
from
0a7cb85 to
878de8a
Compare
jansegre
approved these changes
Jul 17, 2023
Codecov Report
@@ Coverage Diff @@
## master #706 +/- ##
==========================================
+ Coverage 83.99% 84.00% +0.01%
==========================================
Files 246 246
Lines 20517 20517
Branches 2769 2769
==========================================
+ Hits 17233 17236 +3
+ Misses 2709 2707 -2
+ Partials 575 574 -1 |
msbrogli
approved these changes
Jul 18, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I noticed that the event simulator CLI tool was not working correctly due to some previous changes.
Acceptance Criteria
--scenariooption parsingChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged